Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account for LTER and EDI datasets in categorize_dataset #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

account for LTER and EDI datasets in categorize_dataset #218

wants to merge 2 commits into from

Conversation

laijasmine
Copy link

datasets from LTER and EDI that don't use the DOI in the metadata pid. Make sure to include that in the stopifnot check in the beginning.

@mbjones
Copy link
Member

mbjones commented Jul 2, 2021

@laijasmine why does categorize_dataset limit itself to only DOI identifiers? That seems unneeded, and limits the utility of datamgmt to specific repositories. Hardcoding the pasta string into a generic library seems problematic. Can't you just remove the restriction altogether?

@laijasmine
Copy link
Author

@mbjones you are right. Addressed that in the new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laijasmine @mbjones